Re: [PATCH v2] drm/panel: Select DRM_DP_HELPER for DRM_PANEL_EDP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

Am 23.02.22 um 17:11 schrieb Doug Anderson:
Hi,

On Tue, Feb 22, 2022 at 1:31 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:

On Tue, Feb 8, 2022 at 10:39 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
On Mon, Feb 7, 2022 at 12:31 PM Thomas Zimmermann <tzimmermann@xxxxxxx> wrote:
As reported in [1], DRM_PANEL_EDP depends on DRM_DP_HELPER. Select
the option to fix the build failure. The error message is shown
below.

   arm-linux-gnueabihf-ld: drivers/gpu/drm/panel/panel-edp.o: in function
     `panel_edp_probe': panel-edp.c:(.text+0xb74): undefined reference to
     `drm_panel_dp_aux_backlight'
   make[1]: *** [/builds/linux/Makefile:1222: vmlinux] Error 1

The issue has been reported before, when DisplayPort helpers were
hidden behind the option CONFIG_DRM_KMS_HELPER. [2]

v2:
         * fix and expand commit description (Arnd)

Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>

Thanks for your patch!

This fixes the build errors I'm seeing, so
Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Is this planned to be queued? This is still failing in drm-next.
Thanks!

Looks like this has been in drm-misc-next since Feb 4:

---

commit eea89dff4c39a106f98d1cb5e4d626f8c63908b9
Author:     Thomas Zimmermann <tzimmermann@xxxxxxx>
AuthorDate: Thu Feb 3 10:39:22 2022 +0100
Commit:     Thomas Zimmermann <tzimmermann@xxxxxxx>
CommitDate: Fri Feb 4 09:38:47 2022 +0100

     drm/panel: Select DRM_DP_HELPER for DRM_PANEL_EDP

---

Maybe it needed to land elsewhere, though?

Sorry about the mess. We had some confusion with this cycle's drm-misc-next pull request, which got delayed significantly. There's been a PR today, which should be merged into drm-next any time now. The patch will be part of that.

Best regards
Thomas


-Doug

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux