Re: [Intel-gfx] [PATCH v3 2/3] drm/i915/gem: Remove logic for wbinvd_on_all_cpus

[Thomas Hellström (Intel) <thomas_os@xxxxxxxxxxxx>]

Hi, Michael,

On 2/22/22 18:26, Michael Cheng wrote:
> This patch removes logic for wbinvd_on_all_cpus and brings in
> drm_cache.h. This header has the logic that outputs a warning
> when wbinvd_on_all_cpus when its being used on a non-x86 platform.
>
> Signed-off-by: Michael Cheng <michael.cheng@xxxxxxxxx>

Linus has been pretty clear that he won't accept patches that add macros 
that works on one arch and warns on others anymore in i915 and I figure 
even less so in drm code.

So we shouldn't try to move this out to drm. Instead we should restrict 
the wbinvd() inside our driver to integrated and X86 only. For discrete 
on all architectures we should be coherent and hence not be needing 
wbinvd().

Thanks,

/Thomas