Re: [PATCH] drm/panel: simple: Fix Innolux G070Y2-L01 BPP settings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marek,

Thank you for the patch.

On Sun, Feb 20, 2022 at 05:07:18AM +0100, Marek Vasut wrote:
> The Innolux G070Y2-L01 supports two modes of operation:
> 1) FRC=Low/NC ... MEDIA_BUS_FMT_RGB666_1X7X3_SPWG ... BPP=6
> 2) FRC=High ..... MEDIA_BUS_FMT_RGB888_1X7X4_SPWG ... BPP=8
> 
> Currently the panel description mixes both, BPP from 1) and bus
> format from 2), which triggers a warning at panel-simple.c:615.
> 
> Pick the later, set bpp=8, fix the warning.
> 
> Fixes: a5d2ade627dca ("drm/panel: simple: Add support for Innolux G070Y2-L01")
> Signed-off-by: Marek Vasut <marex@xxxxxxx>
> Cc: Christoph Fritz <chf.fritz@xxxxxxxxxxxxxx>
> Cc: Laurent Pinchart <Laurent.pinchart@xxxxxxxxxxxxxxxx>
> Cc: Maxime Ripard <maxime@xxxxxxxxxx>
> Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Thomas Zimmermann <tzimmermann@xxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
>  drivers/gpu/drm/panel/panel-simple.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 49e56adff6226..4405a9dc7574f 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2137,7 +2137,7 @@ static const struct display_timing innolux_g070y2_l01_timing = {
>  static const struct panel_desc innolux_g070y2_l01 = {
>  	.timings = &innolux_g070y2_l01_timing,
>  	.num_timings = 1,
> -	.bpc = 6,
> +	.bpc = 8,
>  	.size = {
>  		.width = 152,
>  		.height = 91,

-- 
Regards,

Laurent Pinchart



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux