Re: [PATCH 08/35] drm/<drivers>: Unified handling of unimplemented fb->create_handle

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 10, 2013 at 09:47:49PM +0100, Daniel Vetter wrote:
[...]
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index 8d665fa..a9abf49 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -2384,7 +2384,10 @@ int drm_mode_getfb(struct drm_device *dev,
>  	r->depth = fb->depth;
>  	r->bpp = fb->bits_per_pixel;
>  	r->pitch = fb->pitches[0];
> -	fb->funcs->create_handle(fb, file_priv, &r->handle);
> +	if (fb->funcs->create_handle)
> +		ret = fb->funcs->create_handle(fb, file_priv, &r->handle);
> +	else
> +		ret = -ENODEV;

Should this perhaps be -ENOSYS?

Thierry

Attachment: pgpaTjC88IHVW.pgp
Description: PGP signature

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux