Due to the typo, none of the .xml files would end up in the release tarball and cause make distcheck as well as builds from the tarball to fail. Using $() isn't strictly necessary but other variables and expressions use that variant already so it makes the usage consistent. Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx> --- man/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/man/Makefile.am b/man/Makefile.am index 25202e2..d25a293 100644 --- a/man/Makefile.am +++ b/man/Makefile.am @@ -17,7 +17,8 @@ MANPAGES_ALIASES = \ drm-ttm.7 XML_FILES = \ - ${patsubst %.1,%.xml,${patsubst %.3,%.xml,${patsubst %.5,%.xml,${patsubs %.7,%.xml,$(MANPAGES)}}}} + $(patsubst %.1,%.xml,$(patsubst %.3,%.xml,$(patsubst %.5,%.xml,$(patsubst %.7,%.xml,$(MANPAGES))))) + EXTRA_DIST = $(XML_FILES) CLEANFILES = $(MANPAGES) $(MANPAGES_ALIASES) .man_fixup man_MANS = -- 1.8.1.1 _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel