Hi, AngeloGioacchino: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> 於 2022年1月18日 週二 下午9:38寫道： > > There is no need to zero out the newly allocated memory because we are > duplicating all members of struct mtk_plane_state: switch to kmalloc > to save some overhead. Reviewed-by: Chun-Kuang Hu <chunkuang.hu@xxxxxxxxxx> > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> > --- > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > index c74cb94e445e..39cb9a80d976 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > @@ -57,7 +57,7 @@ static struct drm_plane_state *mtk_plane_duplicate_state(struct drm_plane *plane > struct mtk_plane_state *old_state = to_mtk_plane_state(plane->state); > struct mtk_plane_state *state; > > - state = kzalloc(sizeof(*state), GFP_KERNEL); > + state = kmalloc(sizeof(*state), GFP_KERNEL); > if (!state) > return NULL; > > -- > 2.33.1 >
