On Thu, Jan 10, 2013 at 11:36 PM, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote: > On Thu, 10 Jan 2013 21:47:53 +0100 > Daniel Vetter <daniel.vetter@xxxxxxxx> wrote: > >> Only two places: >> - suspend/resume >> - Some really strange mode validation tool with too much funny-lucking >> hand-rolled conversion code. >> - The recently-added lastclose fbdev restore code. >> >> Better safe than sorry, so convert both places to keep the locking >> semantics as much as possible. > > Seems fine. The last close behaviour really ought to be in the core DRM > code. Telling people to discover magic incantations with sysrq is a total > fail, especially on tablets and other devices that don't *have* a sysrq > key. I've looked into doing that, but the fbdev emulation is an (optional) driver internal detail. So I've opted for the 2nd best option and unified the logic on all drivers that implement it - some (arm) drivers don't even bother with this :( I think the entire fbdev emulation vs native kms client stuff is ripe for overhaul, see my other patch to prevent fbdev from causing havoc with the i915 kernel testsuite. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
