Hi Steffen, On Mon, Jan 07, 2013 at 13:36:48, Steffen Trumtrar wrote: > On Mon, Jan 07, 2013 at 06:10:13AM +0000, Mohammed, Afzal wrote: > > This breaks DaVinci (da8xx_omapl_defconfig), following change was > > required to get it build if OF_VIDEOMODE or/and FB_MODE_HELPERS > > is not defined. There may be better solutions, following was the > > one that was used by me to test this series. > I just did a quick "make da8xx_omapl_defconfig && make" and it builds just fine. > On what version did you apply the series? > At the moment I have the series sitting on 3.7. Didn't try any 3.8-rcx yet. > But fixing this shouldn't be a problem. You are right, me idiot, error will happen only upon try to make use of of_get_fb_videomode() (defined in this patch) in the da8xx-fb driver (with da8xx_omapl_defconfig), to be exact upon adding, "video: da8xx-fb: obtain fb_videomode info from dt" of my patch series. The change as I mentioned or something similar would be required as any driver that is going to make use of of_get_fb_videomode() would break if CONFIG_OF_VIDEOMODE or CONFIG_FB_MODE_HELPERS is not defined. And testing was done over v3.8-rc2. > > > +#if IS_ENABLED(CONFIG_OF_VIDEOMODE) > > > > As _OF_VIDEOMODE is a bool type CONFIG, isn't, > > > > #ifdef CONFIG_OF_VIDEOMODE > > > > sufficient ? > > > > Yes, that is right. But I think IS_ENABLED is the preferred way to do it, isn't it? Now I realize it is. Regards Afzal _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
