Hi Vikas,
On Wednesday 02 of January 2013 18:47:22 Vikas C Sajjan wrote:
> From: Vikas Sajjan <vikas.sajjan@xxxxxxxxxx>
>
> Signed-off-by: Vikas Sajjan <vikas.sajjan@xxxxxxxxxx>
> ---
> include/video/display.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/video/display.h b/include/video/display.h
> index b639fd0..fb2f437 100644
> --- a/include/video/display.h
> +++ b/include/video/display.h
> @@ -117,6 +117,12 @@ struct dsi_video_source_ops {
>
> void (*enable_hs)(struct video_source *src, bool enable);
>
> + /* frame related */
> + int (*get_frame_done)(struct video_source *src);
> + int (*clear_frame_done)(struct video_source *src);
> + int (*set_early_blank_mode)(struct video_source *src, int power);
> + int (*set_blank_mode)(struct video_source *src, int power);
> +
I'm not sure if all those extra ops are needed in any way.
Looking and Exynos MIPI DSIM driver, set_blank_mode is handling only
FB_BLANK_UNBLANK status, which basically equals to the already existing
enable operation, while set_early_blank mode handles only
FB_BLANK_POWERDOWN, being equal to disable callback.
Both get_frame_done and clear_frame_done do not look at anything used at
the moment and if frame done status monitoring will be ever needed, I
think a better way should be implemented.
Best regards,
--
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Linux Platform
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
