Hi all, First of all, let me quickly introduce myself. I'm José Expósito and I'm a hobbyist open source developer. My contributions are usually in the kernel input/HID subsystems and in its userspace library (libinput) as well as other projects. I'm trying to learn more about the GPU and I found VKMS as a good project to get started. So, now that you have been warned about my (lack) of experience in this subsystem, let's get into the patches. The series adds support for multiple overlay planes by adding a new module parameter that allows to configure the number of overlay planes to add. I checked that the planes are properly created using drm_info[1] and also executed the IGT test "kms_plane" to make sure that the planes were listed in the output. In addition, I checked the vkms_composer and -even though I'm not sure how to properly test it- it looks like it is already prepared to compose an arbitrary number of planes. Having said that, I really hope I didn't make any obvious mistakes. I noticed that the docs say: > For all of these, we also want to review the igt test coverage and > make sure all relevant igt testcases work on vkms I ran some plane related tests, but some of them were already failing without my code, so I'd appreciate some help with this bit. Thank you very much in advance for your time. Any suggestions to improve this patchset or about what to work on next are very welcome. Jose [1] https://github.com/ascent12/drm_info José Expósito (3): drm/vkms: refactor overlay plane creation drm/vkms: add support for multiple overlay planes drm/vkms: drop "Multiple overlay planes" TODO Documentation/gpu/vkms.rst | 2 -- drivers/gpu/drm/vkms/vkms_drv.c | 5 +++++ drivers/gpu/drm/vkms/vkms_drv.h | 1 + drivers/gpu/drm/vkms/vkms_output.c | 29 ++++++++++++++++++++++------- 4 files changed, 28 insertions(+), 9 deletions(-) -- 2.25.1
