[Bug 57842] r200: Culling is broken when rendering to an FBO

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Comment # 13 on bug 57842 from
(In reply to comment #11)
> Created attachment 72051 [details] [review] [review]
> attachment 72047 [details] as patch for r200/radeon
> 
> @comment 9: your own attachment says it was not.
> Anyway, attachment 72047 [details] translated into a patch.
> 
> 'cull_face = (mode == GL_CW) ? R200_FFACE_CULL_CW : R200_FFACE_CULL_CCW'
> is bit of a mouthful, but atm. I've got not idea how to turn that into
> proper obfuscation style of mesa sources.

patch looks correct to me. TCL culling is part of the tcl engine and hence
ignored if there's no TCL. But viewport transform (which is where the fbo
inversion happens) is done later, hence TCL culling is not subject to that
inversion.
FWIW it would also be possible to simply disable TCL culling, setup culling is
enough. The docs are actually saying it TCL culling is a performance
optimization with questionable quality (as the coords aren't snapped to
rasterizer subpixels). I guess it would also be possible to disable setup
culling instead (of course only with tcl) but I'm not sure if that would make
any performance compared to having enabled culling at both places.


You are receiving this mail because:
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux