On Fri, Dec 07, 2012 at 01:11:29PM -0200, Paulo Zanoni wrote: > From: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> > > Use the generic HDMI infoframe helpers to get rid of the duplicate > implementation in the i915 driver. > > This patch is based on the initial patch by Thierry Reding, but with a > different approach. > > TODO: > - The SDVO part is totally untested. I am not sure if the buffer > size on the SDVO code must be a multiple of 4. > - The HDMI part was tested only on SNB/CPT. > - The patch is forcing pixel_repeat to 1 so I can properly test the > patch. Remove this before the final version. > - The correctnes of this patch depends on a fix on patch "video: add > Generic HDMI infoframe helpers" > > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> Hi Paulo, This looks good to me in general. I still think that writing the infoframe to the registers could be refactored some more, but I suppose it could just as well be done in a separate patch. Or not. It's your code after all. Thierry
Attachment:
pgpgA8J9nfyEk.pgp
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
