| What | Removed | Added |
|---|---|---|
| Status | REOPENED | RESOLVED |
| Resolution | --- | FIXED |
Comment # 21
on bug 22576
from Roland Scheidegger
(In reply to comment #18) > I think i've found source of these lighting problems on r200 in this and > other bugs. It is just a typo it seems in r200_state_init.c lit_emit() > > OUT_VEC(atom->cmd[LIT_CMD_1], atom->cmd+LIT_CMD_1+1); > > instead of OUT_VEC it needs to be OUT_SCL: > > OUT_SCL(atom->cmd[LIT_CMD_1], atom->cmd+LIT_CMD_1+1); Should be fixed by 320d531373e7b0873f5de42f6173b986290f593f, thanks! FWIW the command emit mechanism looks a bit too complicated it could profit from some refactoring. For instance it is still based on the fake drm_radeon_cmd_header_t structure, the scl vs. scl2 and vec vs. veclinear emits are nothing but crude hacks around limitations in that structure, even though since ums is gone there is absolutely no point in using that struct... Section size calcs are also somewhat confusing, the sanity code (which was really great back then) is totally unused etc. Maybe another day...
You are receiving this mail because:
- You are the assignee for the bug.
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
