On Fri, 07 Dec 2012, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > On Fri, 07 Dec 2012 13:47:46 +0200, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote: >> >> On Thu, 06 Dec 2012, Tim Gardner <tim.gardner@xxxxxxxxxxxxx> wrote: >> > + if (!saved_mode) { >> > + pr_err("i915: Could not allocate saved display mode.\n"); >> >> Please use DRM_ERROR(). > > Truthfully neither, but join the growing petition to get real errorcodes > back to userspace! Heh, agreed, but in the mean time (i.e. before hell freezes over) I think we should prefer DRM_ERROR over pr_err for consistency. Jani. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel