Just replying to part of your mail. On 30.11.2012 09:22, Thierry Reding wrote: > Actually for the display controller we want just a notification when the > VBLANK happens. I'm not sure if we want to do that with syncpoints at > all since it works quite well using regular interrupts. VBLANK isn't actually a very good example of dc's use of sync points. That can easily be done with regular interrupts, as you mention. More important is when we have double buffering enabled. When you draw something to a surface, and flip it to display, you want DC to notify when the flip has been done and rendering can continue to the back buffer. So, what you can do is return a fence from DC when initiating a flip, and place that fence into 2D stream as a host wait so that 2D will patiently wait for buffer to become free before it renders. > What I'm proposing is to leave it up to each host1x client how they want > to handle this. For display controllers it may be enough to have their > callback run in interrupt context but other clients may need to do more > work so they can queue it themselves. DC doesn't need to worry about host1x interrupts at all. It's all internal to the host1x driver, so we're now just talking about the internal implementation of host1x. We have two scenarios for the syncpt interrupts. One is that a job got finished and we need to clean up the queue and free up resources. This must be done in threads. Other is releasing a thread that is blocked by a syncpt wait. It's simpler if both of these are handled with the same infrastructure, and we've shown that latency is very good even if we handle all events in a thread. > I know that this looks like it might be more work, but if it turns out > that many drivers need to do the exact same thing, that functionality > can be factored out into a helper. But it may just as well turn out that > the requirements for each module are slightly different that forcing a > workqueue on them could result in ugly workarounds because it doesn't > quite work for them. This is just driver internal, so there's no need for other drivers to access this part. > If we move responsibility of managing the workqueue out of host1x as I > proposed above, maybe a lot of this code can be removed. Maybe you can > explain a bit what they are used for exactly in your write-up. It's going to be a big bad boy. :-) Terje _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
