no need to get error code when IS_ERR is false Signed-off-by: Cai Huoqing <caihuoqing@xxxxxxxxx> --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c index e48acdd03c1a..710659b3c1f0 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c @@ -72,16 +72,18 @@ int kfd_chardev_init(void) goto err_register_chrdev; kfd_class = class_create(THIS_MODULE, kfd_dev_name); - err = PTR_ERR(kfd_class); - if (IS_ERR(kfd_class)) + if (IS_ERR(kfd_class)) { + err = PTR_ERR(kfd_class); goto err_class_create; + } kfd_device = device_create(kfd_class, NULL, MKDEV(kfd_char_dev_major, 0), NULL, kfd_dev_name); - err = PTR_ERR(kfd_device); - if (IS_ERR(kfd_device)) + if (IS_ERR(kfd_device)) { + err = PTR_ERR(kfd_device); goto err_device_create; + } return 0; -- 2.25.1