Hi Laurent, On Thu, Nov 22, 2012 at 06:58:09PM +0100, Laurent Pinchart wrote: > Hi Steffen, > > On Thursday 22 November 2012 17:00:13 Steffen Trumtrar wrote: > > Add helper to get fb_videomode from devicetree. > > > > Signed-off-by: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx> > > Reviewed-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx> > > Acked-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx> > > Tested-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx> > > Tested-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > This patch results in the following build warning: > > drivers/video/fbmon.c: In function 'of_get_fb_videomode': > drivers/video/fbmon.c:1445: warning: passing argument 1 of 'of_get_videomode' > discards qualifiers from pointer target type > include/linux/of_videomode.h:15: note: expected 'struct device_node *' but > argument is of type 'const struct device_node *' > This I don't get. Well, looking at the code, the warning is correct. I fixed that now. But, I do not get the warning. Just tried it again before fixing: cleaned, cleaned and touching file, just "make drivers/video/fbmon.o". Nothing. Weird. So, thanks for reporting it. Regards, Steffen -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
