Re: [PATCH 1/4] drm/crtc: Remove redundant NULL check before kfree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dave,

Please ignore this patch.


On 19 November 2012 15:14, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote:
> kfree() on a NULL input is a no-op. Hence remove the check.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
> ---
> This series is build tested on the latest linux-next (20121115).
> ---
>  drivers/gpu/drm/drm_crtc.c |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index 3533609..807336a 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -470,10 +470,8 @@ void drm_crtc_cleanup(struct drm_crtc *crtc)
>  {
>         struct drm_device *dev = crtc->dev;
>
> -       if (crtc->gamma_store) {
> -               kfree(crtc->gamma_store);
> -               crtc->gamma_store = NULL;
> -       }
> +       kfree(crtc->gamma_store);
> +       crtc->gamma_store = NULL;
>
>         drm_mode_object_put(dev, &crtc->base);
>         list_del(&crtc->head);
> --
> 1.7.4.1
>



-- 
With warm regards,
Sachin
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux