On Thu, Apr 15, 2021 at 01:00:40PM +0200, Thomas Zimmermann wrote: > It's only used by DRM_FBDEV_EMULATION, so inline it there. > > Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> I'm not sure on patch 1, I'll leave that to Zack, but I think 2-4 would work alone too. On those: Acked-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > --- > drivers/gpu/drm/Kconfig | 28 +++++++++++----------------- > 1 file changed, 11 insertions(+), 17 deletions(-) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index 3c16bd1afd87..d3a9ca4b1cec 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -80,23 +80,6 @@ config DRM_KMS_HELPER > help > CRTC helpers for KMS drivers. > > -config DRM_KMS_FB_HELPER > - bool > - depends on DRM_KMS_HELPER > - select FB > - select FRAMEBUFFER_CONSOLE if !EXPERT > - select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE > - select FB_SYS_FOPS > - select FB_SYS_FILLRECT > - select FB_SYS_COPYAREA > - select FB_SYS_IMAGEBLIT > - select FB_CFB_FILLRECT > - select FB_CFB_COPYAREA > - select FB_CFB_IMAGEBLIT > - select FB_DEFERRED_IO > - help > - FBDEV helpers for KMS drivers. > - > config DRM_DEBUG_DP_MST_TOPOLOGY_REFS > bool "Enable refcount backtrace history in the DP MST helpers" > depends on STACKTRACE_SUPPORT > @@ -117,6 +100,17 @@ config DRM_FBDEV_EMULATION > depends on DRM > select DRM_KMS_HELPER > select DRM_KMS_FB_HELPER > + select FB > + select FB_CFB_FILLRECT > + select FB_CFB_COPYAREA > + select FB_CFB_IMAGEBLIT > + select FB_DEFERRED_IO > + select FB_SYS_FOPS > + select FB_SYS_FILLRECT > + select FB_SYS_COPYAREA > + select FB_SYS_IMAGEBLIT > + select FRAMEBUFFER_CONSOLE if !EXPERT > + select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE > default y > help > Choose this option if you have a need for the legacy fbdev > -- > 2.31.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
