Hi Rob, Thanks for the patch (0/11 looks a bit weird BTW). On Friday 12 October 2012 18:57:12 Rob Clark wrote: > From: Rob Clark <rob@xxxxxx> > > A helper that drivers can use to send vblank event after a pageflip. > If the driver doesn't support proper vblank irq based time/seqn then > just pass -1 for the pipe # to get do_gettimestamp() behavior (since > there are a lot of drivers that don't use drm_vblank_count_and_time()) > > Also an internal send_vblank_event() helper for the various other code > paths within drm_irq that also need to send vblank events. > > v1: original > v2: add back 'vblwait->reply.sequence = seq' which should not have > been deleted > v3: add WARN_ON() in case lock is not held and comments > v4: use WARN_ON_SMP() instead to fix issue with !SMP && !DEBUG_SPINLOCK > as pointed out by Marcin Slusarz > > Signed-off-by: Rob Clark <rob@xxxxxx> > --- > drivers/gpu/drm/drm_irq.c | 74 ++++++++++++++++++++++++++++-------------- > include/drm/drmP.h | 2 ++ Documentation/DocBook/drm.tmpl is missing ;-) > 2 files changed, 54 insertions(+), 22 deletions(-) I still wish we could have found a way to call drm_vblank_count_and_time() and do_gettimeofday() outside of the spinlock-protected region, but I won't complain. Apart from the missing documentation update the patch looks OK to me. -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
