Re: [PATCH 0/3] Android support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 11, 2012 at 12:39 PM, Tapani Pälli <tapani.palli@xxxxxxxxx> wrote:
> On 10/10/2012 08:05 PM, Chad Versace wrote:
>> On 10/07/2012 10:50 PM, Tapani Pälli wrote:
>>> Upstreaming old set of patches here to enable Android support in libdrm.
>>> Some little rebasing was required for the first one.
>>>
>>> Chad Versace (2):
>>>   libdrm,intel: Factor source file lists into sources.mk
>>>   libdrm,intel: Add Android makefiles (v2)
>>>
>>> Haitao Huang (1):
>>>   Android.mk: use LOCAL_COPY_HEADERS to export headers.
>>>
>>>  Android.mk        | 62 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>  Makefile.am       |  9 ++++----
>>>  intel/Android.mk  | 57 ++++++++++++++++++++++++++++++++++++++++++++++++++
>>>  intel/Makefile.am |  9 ++++----
>>>  intel/sources.mk  | 30 +++++++++++++++++++++++++++
>>>  sources.mk        | 30 +++++++++++++++++++++++++++
>>
>> This series looks good to me. Before committing, though, I'd like to see either
>> an Acked-by or an "Sure, whatever" from one of the regular libdrm_intel committers.
>
> Thanks for checking it out. I've tried out androgenizer as Eric
> suggested but not really convinced we would like to start using it.

To bring an pro-argument for Tapani, this is how it looks to make it
work with androgenizer.
As you can see, it's not much different from the Android.mk itself,
only the variable names changes.


diff --git a/Makefile.am b/Makefile.am
index 273abf9..b200509 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -77,3 +77,23 @@ copy-headers :
 commit-headers : copy-headers
        git add include
        git commit -am "Copy headers from kernel $$(GIT_DIR=$(kernel_source)/.gi
+
+Android.mk: Makefile.am
+               androgenizer \
+               -:PROJECT testlib \
+               -:REL_TOP $(top_srcdir) \
+               -:ABS_TOP $(abs_top_srcdir) \
+               -:SHARED libdrm \
+               -:SOURCES $(LIBDRM_SOURCES) \
+               -:LDFLAGS $(libdrm_la_LDFLAGS) \
+               -:CPPFLAGS $(libdrm_la_CPPFLAGS) \
+               -:TAGS optional\
+               -:HEADERS xf86drm.h          \
+                       include/drm/drm_fourcc.h \
+                       include/drm/drm.h        \
+                       include/drm/drm_mode.h   \
+                       include/drm/drm_sarea.h  \
+                       include/drm/i915_drm.h   \
+                       intel/intel_bufmgr.h     \
+               -:HEADER_TARGET libdrm \
+               > $@


-- 
Regards!
http://groleo.wordpress.com
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux