On Wednesday 05 September 2012 15:27:24 Daniel Vetter wrote: > On Wed, Sep 05, 2012 at 01:53:44AM +0000, Liu, Chuansheng wrote: > > This patch is for introducing the irq thread support in drm_irq. > > > > Why we need irq thread in drm_irq code? > > In our GPU system, the gpu interrupt handler need some time even > 1ms to > > finish, in that case, the whole system will stay in irq disable status. > > One case is: when audio is playing, it sometimes effects the audio > > quality. > > > > So we have to introduce the irq thread in drm_irq, it can help us move > > some heavy work into irq thread and other irq interrupts can be handled > > in time. Also the IRQF_ONESHOT is helpful for irq thread. > > > > Include one patch: > > [PATCH 01/1] drm_irq-Introducing-the-irq_thread-support > > For a kms drm driver (and tbh, doing a non-kms driver today is not a great > idea), there's no reason to use the drm_irq_install/_unistall helpers. Should the documenation be updated to mark those functions as deprecated for new drivers and explain how to handle IRQ (un)registration manually ? > So if you driver has special needs wrt irq handling that don't neatly fit > what the drm_irq stuff provides, simply don't use it - all the generic > code that's there is just to keep non-kms userspace going. -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
