Hi Stefan, Maxime, On Mon, 2021-01-18 at 12:28 +0100, Stefan Wahren wrote: > Hi, > > Am 15.01.21 um 19:39 schrieb Mark Brown: > > On Fri, Jan 15, 2021 at 07:14:37PM +0100, Maxime Ripard wrote: > > > On Wed, Jan 13, 2021 at 11:42:23AM +0000, Mark Brown wrote: > > > > On Wed, Jan 13, 2021 at 10:19:57AM +0100, Maxime Ripard wrote: > > > > > I'd like to get Mark's opinion before merging though > > > > I'm not sure what the question is here? I get CCed on a bunch of not > > > > obviously relevant DRM patches so there's a good chance I've just > > > > deleted some relevnat discussion. > > > The patch is question is here: > > > https://lore.kernel.org/dri-devel/1609256210-19863-1-git-send-email-stefan.wahren@xxxxxxxx/ > > > In particular, I'm not so sure whether it's fine to return -EPROBE_DEFER > > > in the startup hook. > > I wouldn't expect that to do anything useful and IIRC that error code > > will end up in userspace which isn't good. If the driver wants to defer > > probe it should defer it from the probe() routine, after the driver has > > been instantiated I'm not sure what the expectation would be. In > > general a driver should acquire all resources it needs when probing. > > understand. Unfortunately, currently i don't have the time to > investigate how we can achieve this with this drm driver. > > Maybe some else can take over? My two cents: IIUC it's a tricky one since components don't have a way to express dependencies. Somewhat similar to what happened with the DSI bus/display race. To what extent vc4-crtc has a dependency with vc4-hdmi? Couldn't we move vc4-hdmi component's registration at the end of vc4_crtc_bind()? Regards, Nicolas
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
