Re: [PATCH 3/3] Android.mk: use LOCAL_COPY_HEADERS to export headers.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 08, 2012 at 08:50:26AM +0300, Tapani Pälli wrote:
> From: Haitao Huang <haitao.huang@xxxxxxxxx>
> 
> Export necessary header files used by other components for Android,
> such as libva intel-driver, gralloc, hwcomposer, etc.
> 
> Change-Id: I2feabf6941379ef4d756e942f30eba059de641f1
> Signed-off-by: Haitao Huang <haitao.huang@xxxxxxxxx>
> [chad: Fixed inconsistent indentation.]
> Signed-off-by: Chad Versace <chad.versace@xxxxxxxxxxxxxxx>
> ---

Please put "[chad: Fixed inconsistent indentation.]" after the
triple-dash, so that it will not be immortalized into the Git history.
Otherwise, looks fine, does what it says on the box.

Reviewed-by: Oliver McFadden <oliver.mcfadden@xxxxxxxxxxxxxxx>

>  Android.mk | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/Android.mk b/Android.mk
> index 1029dc6..68db5df 100644
> --- a/Android.mk
> +++ b/Android.mk
> @@ -1,5 +1,5 @@
>  #
> -# Copyright © 2011 Intel Corporation
> +# Copyright © 2011-2012 Intel Corporation
>  #
>  # Permission is hereby granted, free of charge, to any person obtaining a
>  # copy of this software and associated documentation files (the "Software"),
> @@ -45,6 +45,16 @@ LOCAL_C_INCLUDES := \
>  LOCAL_CFLAGS := \
>  	-DHAVE_LIBDRM_ATOMIC_PRIMITIVES=1
>  
> +LOCAL_COPY_HEADERS :=            \
> +	xf86drm.h                \
> +	include/drm/drm_fourcc.h \
> +	include/drm/drm.h        \
> +	include/drm/drm_mode.h   \
> +	include/drm/drm_sarea.h  \
> +	include/drm/i915_drm.h   \
> +	intel/intel_bufmgr.h     \
> +
> +LOCAL_COPY_HEADERS_TO := libdrm
>  include $(BUILD_SHARED_LIBRARY)
>  
>  include $(LOCAL_PATH)/intel/Android.mk
> -- 
> 1.7.11.7
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Oliver McFadden.
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux