Thanks Joonyoung, I have addressed your comments in v1 set. Please have a look at them. regards, Rahul Sharma On Tue, Oct 2, 2012 at 1:01 PM, Joonyoung Shim <jy0922.shim@xxxxxxxxxxx> wrote: > Hi, > > > On 09/28/2012 11:25 PM, Rahul Sharma wrote: >> >> This patch set adds the DT based support for Samsung's Exynos5250 in >> DRM-HDMI. >> It includes disabling of hdmi internal interrupt, suppport for platform >> variants for hdmi and mixer, support to disable video processor based on >> platform type and removal of drm common platform data. > > > Looks good to me overall, i commented a bit. > > Thanks. > > >> Rahul Sharma (9): >> drm: exynos: remove drm hdmi platform data struct >> drm: exynos: hdmi: add support for exynos5 ddc >> drm: exynos: hdmi: add support for exynos5 hdmiphy >> drm: exynos: hdmi: add support for platform variants for mixer >> drm: exynos: hdmi: add support to disable video processor in mixer >> drm: exynos: hdmi: add support for exynos5 mixer >> drm: exynos: hdmi: replace is_v13 with version check in hdmi >> drm: exynos: hdmi: add support for exynos5 hdmi >> drm: exynos: hdmi: remove drm common hdmi platform data struct >> >> Tomasz Stanislawski (5): >> media: s5p-hdmi: add HPD GPIO to platform data >> drm: exynos: hdmi: support for platform variants >> drm: exynos: hdmi: fix interrupt handling >> drm: exynos: hdmi: use s5p-hdmi platform data >> drm: exynos: hdmi: turn off HPD interrupt in HDMI chip >> >> drivers/gpu/drm/exynos/exynos_ddc.c | 22 +++- >> drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 51 ++++---- >> drivers/gpu/drm/exynos/exynos_drm_hdmi.h | 2 + >> drivers/gpu/drm/exynos/exynos_hdmi.c | 196 >> ++++++++++++++++++++------- >> drivers/gpu/drm/exynos/exynos_hdmiphy.c | 12 ++- >> drivers/gpu/drm/exynos/exynos_mixer.c | 219 >> ++++++++++++++++++++++-------- >> drivers/gpu/drm/exynos/regs-mixer.h | 2 + >> include/drm/exynos_drm.h | 27 ---- >> include/media/s5p_hdmi.h | 2 + >> 9 files changed, 369 insertions(+), 164 deletions(-) >> >> > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel