Oh, I thought you meant:
#include "drm_basic_types.h"
#include "drm_fourcc.h"
Yours should work too. I don't have a preference vs. what I already have, so if no one says anything, I can switch over to yours.
Thanks,
James
On Mon, Dec 7, 2020 at 2:53 AM Simon Ser <contact@xxxxxxxxxxx> wrote:
On Monday, December 7th, 2020 at 11:49 AM, James Park <james.park@xxxxxxxxxxxxxxxx> wrote:
> That would work, but that's kind of an annoying requirement. I would
> prefer the header to be self-sufficient.
I don't want to make it more confusing than before, but here Pekka (I
think) suggests to replace this:
diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
index 82f3278..5eb07a5 100644
--- a/include/uapi/drm/drm_fourcc.h
+++ b/include/uapi/drm/drm_fourcc.h
@@ -24,7 +24,11 @@
#ifndef DRM_FOURCC_H
#define DRM_FOURCC_H
+#ifdef DRM_FOURCC_STANDALONE
+#include "drm_basic_types.h"
+#else
#include "drm.h"
+#endif
#if defined(__cplusplus)
extern "C" {
With this:
diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
index 82f3278..5eb07a5 100644
--- a/include/uapi/drm/drm_fourcc.h
+++ b/include/uapi/drm/drm_fourcc.h
@@ -24,7 +24,11 @@
#ifndef DRM_FOURCC_H
#define DRM_FOURCC_H
+#include "drm_basic_types.h"
+
+#ifndef DRM_FOURCC_STANDALONE
#include "drm.h"
+#endif
#if defined(__cplusplus)
extern "C" {
That wouldn't change whether the header is self-sufficient or not,
would it?
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
