Re: [PATCH] drm: drm_basic_types.h, DRM_FOURCC_STANDALONE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The original code blocks in drm.h look identical to me. I see:

#include <linux/types.h>
#include <asm/ioctl.h>
typedef unsigned int drm_handle_t;

Good point about drm_basic_types.h. I'll change it to say "Not Linux" after waiting a bit for more feedback.

Thanks,
James

On Mon, Dec 7, 2020 at 1:59 AM Simon Ser <contact@xxxxxxxxxxx> wrote:
On Monday, December 7th, 2020 at 10:55 AM, James Park <james.park@xxxxxxxxxxxxxxxx> wrote:

> I'd noticed the #if could be combined, but they weren't in drm,h when
> they could have been, so I didn't want to depart from the existing
> pattern.

I see. The original code really needed the two branches and
drm_basic_types.h doesn't. But let's see what others think.

> I think "One of the BSDs" is more informative than "Not Linux" if
> that statement is still true. Given the aversion to making drm.h
> robust to Windows, I don't think we want to imply compatibility that
> isn't there.

Well, drm_basic_types.h would be included on Windows as well from
drm_fourcc.h, right?
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux