On Mon, Nov 30, 2020 at 05:04:43PM +0100, Daniel Vetter wrote: > On Mon, Nov 30, 2020 at 11:55:44AM -0400, Jason Gunthorpe wrote: > > On Mon, Nov 30, 2020 at 03:57:41PM +0100, Daniel Vetter wrote: > > > > + err = ioctl(dri->fd, DRM_IOCTL_AMDGPU_GEM_CREATE, &gem_create); > > > > + if (err) > > > > + return err; > > > > + > > > > + *handle = gem_create.out.handle; > > > > + return 0; > > > > +} > > > > + > > > > +static int radeon_alloc(struct dri *dri, size_t size, uint32_t *handle) > > > > > > Tbh radeon chips are old enough I wouldn't care. Also doesn't support p2p > > > dma-buf, so always going to be in system memory when you share. Plus you > > > also need some more flags like I suggested above I think. > > > > What about nouveau? > > Reallistically chances that someone wants to use rdma together with the > upstream nouveau driver are roughly nil. Imo also needs someone with the > right hardware to make sure it works (since the flags are all kinda arcane > driver specific stuff testing is really needed). Well, it would be helpful if we can test the mlx5 part of the implementation, and I have a lab stocked with nouveau compatible HW.. But you are right someone needs to test/etc, so this does not seem like Jianxin should worry Jason _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
