Re: [PATCH v1] drm/bridge: lt9611: Fix handling of 4k panels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I just tested on non 4k display. Looks good to me.

On Mon, 23 Nov 2020 at 04:46, Robert Foss <robert.foss@xxxxxxxxxx> wrote:
4k requires two dsi pipes, so don't report MODE_OK when only a
single pipe is configured. But rather report MODE_PANEL to
signal that requirements of the panel are not being met.

Reported-by: Peter Collingbourne <pcc@xxxxxxxxxx>
Suggested-by: Peter Collingbourne <pcc@xxxxxxxxxx>
Signed-off-by: Robert Foss <robert.foss@xxxxxxxxxx>
Tested-by: John Stultz <john.stultz@xxxxxxxxxx>
Tested-by: Anibal Limon <anibal.limon@xxxxxxxxxx
---
 drivers/gpu/drm/bridge/lontium-lt9611.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
index d734d9402c35..e8eb8deb444b 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
@@ -867,8 +867,14 @@ static enum drm_mode_status lt9611_bridge_mode_valid(struct drm_bridge *bridge,
                                                     const struct drm_display_mode *mode)
 {
        struct lt9611_mode *lt9611_mode = lt9611_find_mode(mode);
+       struct lt9611 *lt9611 = bridge_to_lt9611(bridge);

-       return lt9611_mode ? MODE_OK : MODE_BAD;
+       if (!lt9611_mode)
+               return MODE_BAD;
+       else if (lt9611_mode->intfs > 1 && !lt9611->dsi1)
+               return MODE_PANEL;
+       else
+               return MODE_OK;
 }

 static void lt9611_bridge_pre_enable(struct drm_bridge *bridge)
--
2.27.0

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux