On Thu, Sep 13, 2012 at 11:35 AM, Rob Clark <rob.clark@xxxxxxxxxx> wrote: > note that the test phase doesn't need vblank events, and also > shouldn't -EBUSY if there is still a pending flip[*], so I'd propose > that however we go about pageflip (one super-ioctl, or one per crtc), > we could use the atomic-modeset ioctl for the test step actually, I think I take this back.. one thing that was discussed on IRC, but didn't make it to this email thread is the behavior of non-specified properties. What I am thinking: modeset: unspecified properties revert to default pageflip: unspecified properties preserve current value So I definitely do think there should be two ioctls, and that test for pageflip should go via atomic-pageflip ioctl to be consistent w/ the preserve-current-values approach. Instead I'll just move the is-there-a-pending-vblank to the top of atomic_commit() so it doesn't get in the way if you try to test for frame n+1 while waiting for vblank from frame n. BR. -R _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
