On Fri, Sep 14, 2012 at 05:39:30PM +0200, Daniel Vetter wrote: > On Fri, Sep 14, 2012 at 5:30 PM, Ville Syrjälä > <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > > intel_pipe_set_base() won't disable the pipe or change the size, > > it'll just flip the primary plane. So that doesn't quite explain > > why the call is there, as opposed to being called just from the > > full modeset path. > > intel_pipe_set_base is also called in the modeset case, i.e. when we > could potentially change the height of the mode. And if we wait on a > large enough scanline which doesn't exist in the new mode this would > hang. Yes, I know it's called in both cases. But my point is that there doesn't seem to be any reason to call it in the pure set_base case. > The other callsite of finish_fb is from intel_crtc_disable. Yep. There it does make sense to me. -- Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
