Re: [PATCH V6] drm: edid: add support for E-DDC

[Shirish S <shirish.s12@xxxxxxxxx>]

On Thu, Aug 30, 2012 at 3:58 AM, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote:

On Thu, Aug 30, 2012 at 12:34:06PM +0530, Shirish S wrote:
> @@ -276,15 +283,21 @@ drm_do_probe_ddc_edid(struct i2c_adapter *adapter, unsigned char *buf,
>                               .buf    = buf,
>                       }
>               };
> -             ret = i2c_transfer(adapter, msgs, 2);
> +
> +     /*
> +      * Avoid sending the segment addr to not upset non-compliant ddc
> +      * monitors.
> +      */

Indentation is still wrong. Or is it gettimg mangled by some email server?

I have double checked with checkpatch, i did not get any errors or warnings,

looks like as you are saying may be true.

Requesting for merge! 

> +             ret = i2c_transfer(adapter, &msgs[3 - xfers], xfers);
> +
>               if (ret == -ENXIO) {
>                       DRM_DEBUG_KMS("drm: skipping non-existent adapter %s\n",
>                                       adapter->name);
>                       break;
>               }
> -     } while (ret != 2 && --retries);
> +     } while (ret != xfers && --retries);
>
> -     return ret == 2 ? 0 : -1;
> +     return ret == xfers ? 0 : -1;
>  }
>
>  static bool drm_edid_is_zero(u8 *in_edid, int length)

--

Ville Syrjälä
Intel OTC

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel