On Mon, Aug 27, 2012 at 4:24 PM, Adam Jackson <ajax@xxxxxxxxxx> wrote: > On 8/23/12 7:50 PM, Dave Airlie wrote: >> >> Hi guys (but mainly ajax) >> >> I have a bunch of EDID and quirk stuff outstanding, >> >> I've made a bundle on patchwork for it >> https://patchwork.kernel.org/bundle/airlied/edid-review/ > > > https://patchwork.kernel.org/patch/1364501/ - I'm nervous about this on > non-EDDC monitors, things are touchy enough as it is. Would prefer if we > did the normal 2-message thing for blocks 0 and 1, and only did 3 messages > if segment != 0. > > https://patchwork.kernel.org/patch/1310091/ - nak, the commit message itself > gives away that we're doing else something wrong here. If DISABLE_AUDIO is > sufficient for one driver it should be sufficient for all. > > For the rest (though I have some complaints that aren't enough to justify > saying no): > > Reviewed-by: Adam Jackson <ajax@xxxxxxxxxx> > > Paul's FORCE_REDUCED_BLANKING series makes me nervous about what those > monitors will do over VGA, since from a conversation we had on IRC he hasn't > been able to test that. I asked the closed driver display team about these to see if we had any generic rules for whole classes of monitors and they do not. They keep a small database of displays that need special tweaking and then have a set of options that can be enabled by the user (always use CVT-RB rather than GTF, etc.). There's no generic solution since EDID 1.3 doesn't give us enough info to really enable generic rules on whole classes of monitors and most VGA connectors still use EDID 1.3 with no extension blocks. EDID 1.4 is better, but few VGA connectors on monitors uses it. Other than that, they also rely on the EDID. Alex > > I don't really see the point in the EDID_MFG_ID() bit of the quirks rework. > Have we actually seen a monitor where that field was malformed in a way that > would require it? > > - ajax > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
