Re: [PATCH 1/3] drm: Add missing static storage class specifiers in drm_proc.c file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Any comments on this series?

Regards
Sachin

On 1 August 2012 17:15, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote:
> Fixes the following sparse warning:
> drivers/gpu/drm/drm_proc.c:92:5:
> warning: symbol 'drm_proc_create_files' was not declared. Should it be static?
> drivers/gpu/drm/drm_proc.c:175:5:
> warning: symbol 'drm_proc_remove_files' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/drm_proc.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_proc.c b/drivers/gpu/drm/drm_proc.c
> index 371c695..da457b1 100644
> --- a/drivers/gpu/drm/drm_proc.c
> +++ b/drivers/gpu/drm/drm_proc.c
> @@ -89,7 +89,7 @@ static const struct file_operations drm_proc_fops = {
>   * Create a given set of proc files represented by an array of
>   * gdm_proc_lists in the given root directory.
>   */
> -int drm_proc_create_files(struct drm_info_list *files, int count,
> +static int drm_proc_create_files(struct drm_info_list *files, int count,
>                           struct proc_dir_entry *root, struct drm_minor *minor)
>  {
>         struct drm_device *dev = minor->dev;
> @@ -172,7 +172,7 @@ int drm_proc_init(struct drm_minor *minor, int minor_id,
>         return 0;
>  }
>
> -int drm_proc_remove_files(struct drm_info_list *files, int count,
> +static int drm_proc_remove_files(struct drm_info_list *files, int count,
>                           struct drm_minor *minor)
>  {
>         struct list_head *pos, *q;
> --
> 1.7.4.1
>
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux