[PATCH] drm: Add EDID_QUIRK_FORCE_REDUCED_BLANKING for Philips 32PFL5404H

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Date: Wed, 8 Aug 2012 23:12:19 +0200

< ajax> i would preface this whole discussion with the observation that all tvs are garbage

Connecting the Philips 32PFL5404H [1] a garbled screen is shown with
vertical stripes in the top half.

As written in the referenced Bugzilla #26294 report I am pretty sure
this worked sometime before 2010. My guess is that EDID beforehand was
interpreted incorrectly – as probably MS Windows does – which made it
work.

In commit bc42aabc [2]

        commit bc42aabc6a01b92b0f961d65671564e0e1cd7592
        Author: Adam Jackson <ajax@xxxxxxxxxx>
        Date:   Wed May 23 16:26:54 2012 -0400

            drm/edid/quirks: ViewSonic VA2026w

Adam Jackson added the quirk `EDID_QUIRK_FORCE_REDUCED_BLANKING` which
is also needed for this Philips TV.

The problem is that the Model number is set to zero. I hope this will
not break other Philips TVs out there.

All log files and output from `xrandr` is included in the referenced
Bugzilla report #26294.

[1] http://www.p4c.philips.com/cgi-bin/dcbint/cpindex.pl?ctn=32PFL5404H/12&scy=DE&slg=de
[2] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=bc42aabc6a01b92b0f961d65671564e0e1cd7592

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=26294
Tested-by: Paul Menzel <paulepanter@xxxxxxxxxxxxxxxxxxxxx>
    (ASUS Eee PC 701 4G with Debian Sid/unstable connected over VGA)
Signed-off-by: Paul Menzel <paulepanter@xxxxxxxxxxxxxxxxxxxxx>
Cc: <dri-devel@xxxxxxxxxxxxxxxxxxxxx>
Cc: Adam Jackson <ajax@xxxxxxxxxx>
Cc: Ian Pilcher <arequipeno@xxxxxxxxx>
Cc: <stable@xxxxxxxxxxxxxxx>
---
Ian, I did not base this patch on your series, to make it easier to get
back ported. I can easily rebase it though, so hopefully some maintainer
can tell me what to do.

I also do not know if URLs in the quirk comments are considered useful
or not.
---
 drivers/gpu/drm/drm_edid.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index a8743c3..eb452e6 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -111,6 +111,11 @@ static struct edid_quirk {
 	{ "LPL", 0, EDID_QUIRK_DETAILED_USE_MAXIMUM_SIZE },
 	{ "LPL", 0x2a00, EDID_QUIRK_DETAILED_USE_MAXIMUM_SIZE },
 
+	/* Philips 32PFL5404H TV */
+	/* http://www.p4c.philips.com/cgi-bin/dcbint/cpindex.pl?ctn=32PFL5404H/12&scy=DE&slg=de */
+	/* https://bugs.freedesktop.org/show_bug.cgi?id=26294 */
+	{ "PHL", 0, EDID_QUIRK_FORCE_REDUCED_BLANKING },
+
 	/* Philips 107p5 CRT */
 	{ "PHL", 57364, EDID_QUIRK_FIRST_DETAILED_PREFERRED },
 
-- 
1.7.10.4

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux