From: Bernard Zhao <bernard@xxxxxxxx> Date: 2020-04-27 16:05:23 To: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>,Uma Shankar <uma.shankar@xxxxxxxxx>,"Ville Syrjälä" <ville.syrjala@xxxxxxxxxxxxxxx>,Shashank Sharma <shashank.sharma@xxxxxxxxx>,Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>,Daniel Vetter <daniel.vetter@xxxxxxxx>,Bernard Zhao <bernard@xxxxxxxx>,dri-devel@xxxxxxxxxxxxxxxxxxxxx,linux-fbdev@xxxxxxxxxxxxxxx,linux-kernel@xxxxxxxxxxxxxxx Cc: opensource.kernel@xxxxxxxx Subject: [PATCH] drivers/video: cleanup coding style in video a bit>Eliminate the magic numbers, add vender infoframe size macro >like other hdmi modules. > >Signed-off-by: Bernard Zhao <bernard@xxxxxxxx> >--- > drivers/video/hdmi.c | 2 +- > include/linux/hdmi.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > >diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c >index 856a8c4e84a2..f693076f2e5f 100644 >--- a/drivers/video/hdmi.c >+++ b/drivers/video/hdmi.c >@@ -495,7 +495,7 @@ int hdmi_vendor_infoframe_init(struct hdmi_vendor_infoframe *frame) > * value > */ > frame->s3d_struct = HDMI_3D_STRUCTURE_INVALID; >- frame->length = 4; >+ frame->length = HDMI_VENDOR_INFOFRAME_SIZE; > > return 0; > } >diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h >index 9613d796cfb1..ff25aeb95ee4 100644 >--- a/include/linux/hdmi.h >+++ b/include/linux/hdmi.h >@@ -57,6 +57,7 @@ enum hdmi_infoframe_type { > #define HDMI_SPD_INFOFRAME_SIZE 25 > #define HDMI_AUDIO_INFOFRAME_SIZE 10 > #define HDMI_DRM_INFOFRAME_SIZE 26 >+#define HDMI_VENDOR_INFOFRAME_SIZE 4 > > #define HDMI_INFOFRAME_SIZE(type) \ > (HDMI_INFOFRAME_HEADER_SIZE + HDMI_ ## type ## _INFOFRAME_SIZE) >-- >2.26.2 > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel