Leela Krishna Amudala wrote: > > Hello Kgene, > > On Wed, Aug 1, 2012 at 7:34 AM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote: > > Leela Krishna Amudala wrote: > >> > >> The FIMD register headers are moved to include/video/ > >> hence, deleting these files from platform side > >> > >> Signed-off-by: Leela Krishna Amudala <l.krishna@xxxxxxxxxxx> > >> --- > >> arch/arm/plat-samsung/include/plat/regs-fb-v4.h | 159 --------- > >> arch/arm/plat-samsung/include/plat/regs-fb.h | 403 > > ------------------- > >> ---- > >> 2 files changed, 0 insertions(+), 562 deletions(-) > >> delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb-v4.h > >> delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb.h > >> > > No. This should be squashed into first patch on this series. See below. > > > > arch/arm/plat-samsung/include/plat/regs-fb-v4.h | 159 > > -------------------- > > .../plat/regs-fb.h => include/video/samsung_fimd.h | 145 > > ++++++++++++++++-- > > 2 files changed, 134 insertions(+), 170 deletions(-) > > delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb-v4.h > > rename arch/arm/plat-samsung/include/plat/regs-fb.h => > > include/video/samsung_fimd.h (74%) > > > > If I squash it with the first patch and if somebody set that as a head > commit, it will break the build. Hence, splitted it up from the first > patch. > NACK. your changes are not adding just moving. So should be squashed. If required, you could create just one patch for moving them, probably, 1st, 3rd, 4th and 5th patches into one patch. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. > Thank you Sylwester for suggesting this split up change. > > Regards, > Leela Krishna _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
