On Tue, Jul 31, 2012 at 4:05 PM, Luca Tettamanti <kronos.it@xxxxxxxxx> wrote: > On Tue, Jul 31, 2012 at 09:58:04AM -0400, Alex Deucher wrote: >> On Tue, Jul 31, 2012 at 5:16 AM, Luca Tettamanti <kronos.it@xxxxxxxxx> wrote: >> > On Mon, Jul 30, 2012 at 10:45 PM, Alex Deucher <alexdeucher@xxxxxxxxx> wrote: >> >> Regarding patches 3 and 4, it might be easier to just store a pointer >> >> to the relevant encoder when you verify ATIF rather than walking the >> >> encoder list every time. > > Done. > >> > Makes sense, I was unsure about the lifetime of the encoders, but >> > AFAICS they're destroyed only when the module in unloaded. >> >> They are present for the life of the driver. > > I had to move to call to radeon_acpi_init after radeon_modeset_init, > otherwise the encoders are not present yet (the tear down code path is > correct, acpi first, then modeset). > Latest and greatest version is attached; I fixed notifications when > using custom command codes (tested by Pali Rohár) and implemented your > suggestion. Patches look good. I picked them up and combined them with may patches plus a few other small fixes. They are available here: http://cgit.freedesktop.org/~agd5f/linux/log/?h=acpi_patches Let me know what you think. Alex _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
