On Tue, Jul 31, 2012 at 12:43 AM, Dave Airlie <airlied@xxxxxxxxx> wrote: > On Tue, Jul 31, 2012 at 12:45 AM, Alex Deucher <alexdeucher@xxxxxxxxx> wrote: >> On Fri, Jul 27, 2012 at 5:34 PM, Lauri Kasanen <cand@xxxxxxx> wrote: >>> Let's allow GCC to optimize better. >>> >>> This exposed some five unused functions, but this patch doesn't remove them. >>> >>> Signed-off-by: Lauri Kasanen <cand@xxxxxxx> >> >> Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx> > > You might want to take this one step further and fix all the warnings > it introduces here, I think these are mostly left-overs from porting code from the ddx. All can be safely removed. > > CC [M] drivers/gpu/drm/radeon/radeon_combios.o > /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/radeon/radeon_combios.c:3307:13: > warning: ‘radeon_combios_dyn_clk_setup’ defined but not used > [-Wunused-function] Can be removed. COMBIOS_DYN_CLK_1_TABLE is already parsed in radeon_combios_asic_init(). radeon_combios_dyn_clk_setup() is redundant. > CC [M] drivers/gpu/drm/radeon/radeon_legacy_crtc.o > /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/radeon/radeon_legacy_crtc.c:209:13: > warning: ‘radeon_restore_common_regs’ defined but not used > [-Wunused-function] Can be removed. The function is empty. It was a leftover from the ddx save/restore code. > > CC [M] drivers/gpu/drm/radeon/r100.o > /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/radeon/r100.c:2548:13: > warning: ‘r100_gpu_wait_for_vsync’ defined but not used > [-Wunused-function] > /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/radeon/r100.c:2570:13: > warning: ‘r100_gpu_wait_for_vsync2’ defined but not used > [-Wunused-function] Both can be removed. Remnants from the ddx. Alex _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
