On Mon, Jul 30, 2012 at 4:24 PM, Luca Tettamanti <kronos.it@xxxxxxxxx> wrote: > On Mon, Jul 30, 2012 at 10:20:15AM -0400, Alex Deucher wrote: >> On Sun, Jul 29, 2012 at 9:06 AM, Luca Tettamanti <kronos.it@xxxxxxxxx> wrote: >> > On Sat, Jul 28, 2012 at 05:29:25PM -0400, Alex Deucher wrote: >> >> On Sat, Jul 28, 2012 at 10:56 AM, Luca Tettamanti <kronos.it@xxxxxxxxx> wrote: >> >> > I just found the first problem (probably a BIOS bug): >> >> > ATIF_FUNCTION_GET_SYSTEM_PARAMETERS is implemented in the DSDT, but the >> >> > corresponding bit ATIF_GET_SYSTEM_PARAMETERS_SUPPORTED is not set :( >> >> > I intended to use the method to set up the notification handler but now >> >> > my BIOS says that it's not there even if it is... >> >> > Can I assume some default values (e.g. notifications are enabled and will >> >> > use 0x81 unless ATIF_FUNCTION_GET_SYSTEM_PARAMETERS says something >> >> > different)? >> >> >> >> The spec says that the bits in the supported functions vector mean >> >> that if bit n is set, function n+1 exists, >> > >> > Hum, I don't follow. The vector in my case is 0x2 (1 << 1), that would >> > mean that ATIF_SELECT_ACTIVE_DISPLAYS_SUPPORTED (1 << 2) is supported? >> > >> > Maybe if the bit n is set then functions 0..n are available? That would >> > (almost) match what I see... >> >> From the spec: >> >> Supported DWORD Bit vector providing supported functions >> information. Each bit marks >> Functions Bit support for one specific function of the >> ATIF method. Bit n, if set, >> Vector indicates that Function n+1 is supported. > > Sorry, I still don't understand it... what's "Function n+1" in this > context? > Does this mean that if bit n is set then the function defined as > 1 << (n+1) is supported? It means if bit n is set in teh supported function vector, function n+1 is supported. E.g., if bit 1 is set, function 2 (ATIF_FUNCTION_GET_SYSTEM_BIOS_REQUESTS) is supported. If bit 3 is set function 4 (ATIF_FUNCTION_GET_LID_STATE) is supported, etc. Alex > >> I don't know how wonky bioses in the wild are however. I can see what >> our internal teams do in these sort of cases. > > That would be helpful :) > Note that on this machine (Toshiba L855-10W) brightness control under > windows does not work with the stock catalyst driver, it works only with > the (oldish) driver supplied by Toshiba. > > Anyway, I'm attaching v2 of my patches, I've incorporated the > suggestions and some bits of code from joeyli, and now brightness > control is actually implemented. > > Still missing is the issue of event 0x81 and the conflict with video.ko; > the handler should probably return NOTIFY_BAD to veto the keypress. > > Luca _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
