Hi, On 07/30/2012 10:53 AM, Jingoo Han wrote: >> +/*FIMD V8 REG OFFSET */ >> +#define FIMD_V8_VIDTCON0 (0x20010) >> +#define FIMD_V8_VIDTCON1 (0x20014) >> +#define FIMD_V8_VIDTCON2 (0x20018) >> +#define FIMD_V8_VIDTCON3 (0x2001C) >> +#define FIMD_V8_VIDCON1 (0x20004) > > > CC'ed Marek. > > To Leela Krishna Amudala, > > Don't add these definitions for FIMD_V8_xxx registers, which are > not related to current "regs-fb-v4.h and regs-fb.h". > Just "move" and "merge" regs-fb-v4.h and regs-fb.h to one header > file, not "add" new definitions. > If you want to add these definitions, please make new patch for this. Good point. > Also, "#define FIMD_V8_xxx" is ugly. > I think that there is better way. > Please, find other way. Instead of just telling that something is wrong and you don't like it, perhaps it would be kind to give at least a slight suggestion of what would have been good enough to your taste...respecting someone else's time and effort. So what would you like to see there instead, EXYNOS5_FIMD_* ? BTW, your e-mails are badly word wrapped, I had to manually correct it. -- Regards, Sylwester _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
