Generic fbdev emulation is a DRM client. If possible, it should behave
like userspace clients. Therefore it should not run before the driver
registered the new DRM device. If the setup function fails, the driver
should not report an error.
This is a follow-up patchset to the discussion at [1]. I went
through all calls to drm_fbdev_generic_setup(), moved them to the
final operation of their driver's probe function, and removed the
return value.
Built on x86-64, aarch64 and arm. Tested with mgag200.
v2:
* warn in drm_fbdev_generic_setup() if device is unregistered (Jani)
* document the new behavior (Sam)
* fix mediatek subject (Noralf)
* keep kirin patch for now, even though the patched code will
probably be removed
Thomas Zimmermann (10):
drm/ast: Set up fbdev after registering device; remove error checks
drm/hibmc: Remove error check from fbdev setup
drm/kirin: Set up fbdev after fully registering device
drm/ingenic: Remove error check from fbdev setup
drm/mediatek: Remove error check from fbdev setup
drm/mgag200: Set up fbdev after registering device; remove error
checks
drm/tilcdc: Set up fbdev after fully registering device
drm/udl: Remove error check from fbdev setup
drm/vboxvideo: Set up fbdev after registering device; remove error
checks
drm/fb-helper: Remove return value from drm_fbdev_generic_setup()
drivers/gpu/drm/ast/ast_drv.c | 3 +++
drivers/gpu/drm/ast/ast_main.c | 5 ----
drivers/gpu/drm/drm_fb_helper.c | 25 ++++++++++---------
.../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 6 +----
.../gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 4 +--
drivers/gpu/drm/ingenic/ingenic-drm.c | 4 +--
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 4 +--
drivers/gpu/drm/mgag200/mgag200_drv.c | 2 ++
drivers/gpu/drm/mgag200/mgag200_main.c | 4 ---
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 3 +--
drivers/gpu/drm/udl/udl_drv.c | 6 +----
drivers/gpu/drm/vboxvideo/vbox_drv.c | 6 ++---
include/drm/drm_fb_helper.h | 5 ++--
13 files changed, 30 insertions(+), 47 deletions(-)
--
2.26.0
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
