Re: [PATCH] drm: panel-orientation-quirks: 320 FHD and D330 HD

[Hans de Goede <hdegoede@xxxxxxxxxx>]

Hi,

On 3/31/20 6:44 PM, Jani Nikula wrote:
> On Fri, 27 Mar 2020, David Santamaría Rogado <howl.nsp@xxxxxxxxx> wrote:
> > This patch is still valid as no changes to panel orientation quirks
> > have been done. Someone can review this to merge?
>
> Cc: Hans.

Looks good to me:

Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Regards,

Hans




> > El mar., 30 jul. 2019 a las 21:49, David Santamaría Rogado
> > (<howl.nsp@xxxxxxxxx>) escribió:
> > > This adds the HD version of Lenovo Ideapad D330
> > > and FHD version of Lenovo Ideapad Miix 320.
> > >
> > > This should work despite the dmi data is the same because
> > > the resolution checks.
> > >
> > > Signed-off-by: David Santamaría Rogado <howl.nsp@xxxxxxxxx>
> > > ---
> > >   drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++++++++++++++++--
> > >   1 file changed, 16 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > > index ffd95bfeaa94..896c783ce135 100644
> > > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > > @@ -191,14 +191,28 @@ static const struct dmi_system_id orientation_data[] = {
> > >                    DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"),
> > >                  },
> > >                  .driver_data = (void *)&lcd800x1280_rightside_up,
> > > -       }, {    /* Lenovo Ideapad Miix 320 */
> > > +       }, {    /* Lenovo Ideapad Miix 320 (HD) */
> > >                  .matches = {
> > >                    DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> > >                    DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
> > >                    DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
> > >                  },
> > >                  .driver_data = (void *)&lcd800x1280_rightside_up,
> > > -       }, {    /* Lenovo Ideapad D330 */
> > > +       }, {    /* Lenovo Ideapad Miix 320 (FHD) */
> > > +               .matches = {
> > > +                 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> > > +                 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
> > > +                 DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
> > > +               },
> > > +               .driver_data = (void *)&lcd1200x1920_rightside_up,
> > > +       }, {    /* Lenovo Ideapad D330 (HD) */
> > > +               .matches = {
> > > +                 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> > > +                 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
> > > +                 DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),
> > > +               },
> > > +               .driver_data = (void *)&lcd800x1280_rightside_up,
> > > +       }, {    /* Lenovo Ideapad D330 (FHD) */
> > >                  .matches = {
> > >                    DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> > >                    DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
> > > --
> > > 2.21.0

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel