On 2020-03-10 19:54, Sam Ravnborg wrote:
A few things to improve.
The binding should be a separate patch.
subject - shall start with dt-bindings:
Shall be sent to deveicetree mailing list.
Hi Sam,
Thank you very much for your review.
I did consider this. The reason I combined the patches, is that the
binding depends on the display so I thought they were related in some
way. Didn't know the correct procedure to handle this. I will split them
apart in v2.
---
.../display/panel/starry,kr070pe2t.txt | 7 +++++
drivers/gpu/drm/panel/panel-simple.c | 26
+++++++++++++++++++
2 files changed, 33 insertions(+)
create mode 100644
Documentation/devicetree/bindings/display/panel/starry,kr070pe2t.txt
diff --git
a/Documentation/devicetree/bindings/display/panel/starry,kr070pe2t.txt
b/Documentation/devicetree/bindings/display/panel/starry,kr070pe2t.txt
new file mode 100644
index 000000000..699ad5eb2
--- /dev/null
+++
b/Documentation/devicetree/bindings/display/panel/starry,kr070pe2t.txt
@@ -0,0 +1,7 @@
+Starry 7" (800x480 pixels) LCD panel
+
+Required properties:
+- compatible: should be "starry,kr070pe2t"
+
+This binding is compatible with the simple-panel binding, which is
specified
+in simple-panel.txt in this directory.
diff --git a/drivers/gpu/drm/panel/panel-simple.c
b/drivers/gpu/drm/panel/panel-simple.c
index e14c14ac6..027a2612b 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2842,6 +2842,29 @@ static const struct panel_desc
shelly_sca07010_bfn_lnn = {
.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
};
+static const struct drm_display_mode starry_kr070pe2t_mode = {
+ .clock = 33000,
+ .hdisplay = 800,
+ .hsync_start = 800 + 209,
+ .hsync_end = 800 + 209 + 1,
+ .htotal = 800 + 209 + 1 + 45,
+ .vdisplay = 480,
+ .vsync_start = 480 + 22,
+ .vsync_end = 480 + 22 + 1,
+ .vtotal = 480 + 22 + 1 + 22,
+ .vrefresh = 60,
+};
Please adjust so:
vrefresh * htotal * vtotal == clock.
I cannot say what needs to be adjusted.
But we are moving away from specifying vrefresh and want the
data to be OK.
Just like Ville Syrjälä, I ran the numbers and vrefresh indeed
calculates to 59.58.
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
