On 1/6/20 9:13 AM, Masahiro Yamada wrote: > The objects in $(fb-objs) $(fb-y) $(fb-m) are linked to fb.ko . > > This line adds $(fb-y) to fb-objs, so the objects from $(fb-y) are > listed twice as the dependency of the module. > > It works because Kbuild trims the duplicated objects from linking, > but there is no good reason to have this line. > > Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx> Patch queued for v5.6, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > > drivers/video/fbdev/core/Makefile | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/video/fbdev/core/Makefile b/drivers/video/fbdev/core/Makefile > index 37710316a680..26cbc965497c 100644 > --- a/drivers/video/fbdev/core/Makefile > +++ b/drivers/video/fbdev/core/Makefile > @@ -16,7 +16,6 @@ fb-y += fbcon_rotate.o fbcon_cw.o fbcon_ud.o \ > fbcon_ccw.o > endif > endif > -fb-objs := $(fb-y) > > obj-$(CONFIG_FB_CFB_FILLRECT) += cfbfillrect.o > obj-$(CONFIG_FB_CFB_COPYAREA) += cfbcopyarea.o > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
