On Mon, Dec 16, 2019 at 5:12 AM Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> wrote: > > This is my attempt at adding devfreq (and cooling device) support to > the lima driver. > I didn't have much time to do in-depth testing. However, I'm sending > this out early because there are many SoCs with Mali-400/450 GPU so > I want to avoid duplicating the work with somebody else. > > The code is derived from panfrost_devfreq.c which is why I kept the > Collabora copyright in lima_devfreq.c. Please let me know if I should > drop this or how I can make it more clear that I "borrowed" the code > from panfrost. I think it's more common to have separate copyright notices. First you have yours, then a second paragraph stating the code is derived from foo, and then attach the copyright statements for foo. ChenYu > I am seeking comments in two general areas: > - regarding the integration into the existing lima code > - for the actual devfreq code (I had to adapt the panfrost code > slightly, because lima uses a bus and a GPU/core clock) > > My own TODO list includes "more" testing on various Amlogic SoCs. > So far I have tested this on Meson8b and Meson8m2 (which both have a > GPU OPP table defined). However, I still need to test this on a GXL > board (which is currently missing the GPU OPP table). > > > Martin Blumenstingl (1): > drm/lima: Add optional devfreq support > > drivers/gpu/drm/lima/Kconfig | 1 + > drivers/gpu/drm/lima/Makefile | 3 +- > drivers/gpu/drm/lima/lima_devfreq.c | 162 ++++++++++++++++++++++++++++ > drivers/gpu/drm/lima/lima_devfreq.h | 15 +++ > drivers/gpu/drm/lima/lima_device.c | 4 + > drivers/gpu/drm/lima/lima_device.h | 11 ++ > drivers/gpu/drm/lima/lima_drv.c | 14 ++- > drivers/gpu/drm/lima/lima_sched.c | 7 ++ > drivers/gpu/drm/lima/lima_sched.h | 3 + > 9 files changed, 217 insertions(+), 3 deletions(-) > create mode 100644 drivers/gpu/drm/lima/lima_devfreq.c > create mode 100644 drivers/gpu/drm/lima/lima_devfreq.h > > -- > 2.24.1 > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
