https://bugs.freedesktop.org/show_bug.cgi?id=50980 Bug #: 50980 Summary: [r300g, bisected] WebGL cars demo crash (r300_emit.c:865:r300_emit_vertex_arrays: Assertion `(buf)' failed) Classification: Unclassified Product: Mesa Version: git Platform: Other URL: http://www.chromeexperiments.com/detail/webgl-cars/?f= webgl OS/Version: All Status: NEW Keywords: regression Severity: normal Priority: medium Component: Drivers/Gallium/r300 AssignedTo: dri-devel@xxxxxxxxxxxxxxxxxxxxx ReportedBy: pavel.ondracka@xxxxxxxx CC: maraeo@xxxxxxxxx Created attachment 62902 --> https://bugs.freedesktop.org/attachment.cgi?id=62902 backtrace WebGL cars demo crash with r300_emit.c:865:r300_emit_vertex_arrays: Assertion `(buf)' failed, full backtrace attached. 784dd51198433e5c299da4a7742c68d21d68d1c1 is the first bad commit commit 784dd51198433e5c299da4a7742c68d21d68d1c1 Author: Marek Olšák <maraeo@xxxxxxxxx> Date: Mon Apr 16 03:34:22 2012 +0200 mesa,vbo: properly detect when vertex arrays need to be recalculated This moves the RebindArrays flag into the vbo module, consolidates the code, and adds missing vbo_draw_method calls. Also with this change, the vertex arrays are not needlessly recalculated twice. The issue with the old code was: - If recalculate_input_bindings updates vp_varying_inputs, _NEW_ARRAY is set. - _mesa_update_state is called and the vp_varying_inputs change causes regeneration of the fixed-function shaders, which also sets _NEW_PROGRAM. - The occurence of either _NEW_ARRAY or _NEW_PROGRAM sets the recalculate_inputs flag to TRUE again. - The new code sets the flag to FALSE after the second _mesa_update_state, because there can't possibly be any change which would require recalculating the arrays. Reviewed-by: Brian Paul <brianp@xxxxxxxxxx> Reviewed-by: Mathias Fröhlich <Mathias.Froehlich@xxxxxx> GPU:RV530 Kernel: 3.4.0-1.fc17.i686 Firefox 13.0 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
