That's probably safest, however on Intel we can change the stride and tiling format for sync flips at least. But I'm ok with this patch; we generally need to recalculate bw requirements and watermarks when adjusting depth and such. On Thu, 31 May 2012 15:54:03 -0400 Alex Deucher <alexdeucher@xxxxxxxxx> wrote: > On Thu, May 31, 2012 at 3:44 PM, Singh, Satyeshwar > <satyeshwar.singh@xxxxxxxxx> wrote: > > Does this by extension mean that stride changes should also not be allowed while page flipping? > > Everything beyond a crtc base address change should require a full modeset. > > Alex > > > Thanks, > > Satyeshwar > > > > -----Original Message----- > > From: dri-devel-bounces+satyeshwar.singh=intel.com@xxxxxxxxxxxxxxxxxxxxx [mailto:dri-devel-bounces+satyeshwar.singh=intel.com@xxxxxxxxxxxxxxxxxxxxx] On Behalf Of Laurent Pinchart > > Sent: Thursday, May 31, 2012 9:26 AM > > To: dri-devel@xxxxxxxxxxxxxxxxxxxxx > > Subject: [PATCH 1/2] drm: Don't allow page flip to change pixel format > > > > A page flip is not a mode set, changing the frame buffer pixel format doesn't make sense and isn't handled by most drivers anyway. Disallow it. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > --- > > drivers/gpu/drm/drm_crtc.c | 8 ++++++++ > > 1 files changed, 8 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 92cea9d..0d15b56 100644 > > --- a/drivers/gpu/drm/drm_crtc.c > > +++ b/drivers/gpu/drm/drm_crtc.c > > @@ -3530,6 +3530,14 @@ int drm_mode_page_flip_ioctl(struct drm_device *dev, > > goto out; > > } > > > > + if (crtc->fb->pixel_format != fb->pixel_format || > > + crtc->fb->bits_per_pixel != crtc->fb->bits_per_pixel || > > + crtc->fb->depth != fb->depth) { > > + DRM_DEBUG_KMS("Page flip is not allowed to change frame buffer format.\n"); > > + ret = -EINVAL; > > + goto out; > > + } > > + > > if (page_flip->flags & DRM_MODE_PAGE_FLIP_EVENT) { > > ret = -ENOMEM; > > spin_lock_irqsave(&dev->event_lock, flags); > > -- > > 1.7.3.4 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@xxxxxxxxxxxxxxxxxxxxx > > http://lists.freedesktop.org/mailman/listinfo/dri-devel > > _______________________________________________ > > dri-devel mailing list > > dri-devel@xxxxxxxxxxxxxxxxxxxxx > > http://lists.freedesktop.org/mailman/listinfo/dri-devel > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Jesse Barnes, Intel Open Source Technology Center _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
