On 05/31/2012 10:08 AM, Sascha Hauer wrote: > [...] > diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c > new file mode 100644 > index 0000000..d8c0dc7 > --- /dev/null > +++ b/drivers/gpu/drm/drm_gem_cma_helper.c > @@ -0,0 +1,243 @@ > +/* > + * drm gem cma (contiguous memory allocator) helper functions > + * > + * Copyright (C) 2012 Sascha Hauer, Pengutronix > + * > + * Based on Samsung Exynos code > + * > + * Copyright (c) 2011 Samsung Electronics Co., Ltd. > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License > + * as published by the Free Software Foundation; either version 2 > + * of the License, or (at your option) any later version. > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > +#include <drm/drmP.h> > +#include <drm/drm.h> > +#include <drm/drm_gem_cma_helper.h> Sorry, forgot to mention this during the v1 review. This needs '#include <linux/export.h>' for EXPORT_SYMBOL_GPL. I get compile errors otherwise. Maybe it also makes sense to include linux/slab.h, linux/dma-mapping.h, linux/mm.h and linux/mutex.h since those are only implicitly included right now. - Lars _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel