Hello, I tried another script for the semantic patch language out. This source code analysis approach points a call of the member function “get_config_mode” out for further considerations according to the implementation of the function “mdfld_dsi_output_init”. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/gma500/mdfld_dsi_output.c?id=531e93d11470aa2e14e6a3febef50d9bc7bab7a1#n523 https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/gpu/drm/gma500/mdfld_dsi_output.c#L523 … dsi_config->fixed_mode = p_vid_funcs->get_config_mode(dev); if (p_vid_funcs->get_panel_info(dev, pipe, &dsi_panel_info)) goto dsi_init_err0; … dsi_config->mode = dsi_config->fixed_mode; … if (!dsi_config->fixed_mode) { DRM_ERROR("No pannel fixed mode was found\n"); goto dsi_init_err0; } … How do you think about to move the condition check for the data structure member “fixed_mode” directly after the corresponding assignment? Can it be helpful to reorder these statements a bit? Regards, Markus _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
